Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed padding between footer social icons #322

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shubhsaur
Copy link

Fix: #321

Copy link
Contributor

@krilnon krilnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small suggestion for style.

More broadly, although I think this change would indeed fix the issue for the book's footer, a decent amount of the style info comes from https://swift.org/assets/stylesheets/docc/footer.css, which we share with the DocC documentation. It lives over in the swiftlang/swift-org-website repository.

Maybe that's a better place to make a change to fix this, since it'd help the DocC docs too.

TSPL.docc/footer.html Outdated Show resolved Hide resolved
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
@shubhsaur
Copy link
Author

Hey @krilnon, thanks for the suggestion, will look into that way as well, and for the time being have made the requested change

@krilnon krilnon requested a review from amartini51 July 9, 2024 21:40
@krilnon
Copy link
Contributor

krilnon commented Jul 9, 2024

@amartini51 If you have thoughts one way or the other on accepting the quick fix here or waiting for a possible upstream fix, your input is welcome.

@amartini51
Copy link
Member

Thanks for working on this fix! (I was out of the office for 2 weeks when this PR first came through. Thanks for your patience waiting for review.) I'd prefer to correct the CSS in the main Swift.org repo, and then match that correction here. I think that will also get you better review on the CSS, since there are more folks working on that repository with an expertise in CSS. I only know CSS at a general level, and have not kept up with all the latest changes.

@amartini51
Copy link
Member

Moving this PR to "draft" while the changes are being proposed and reviewed for the main Swift.org website. After we merge the changes there, we'll make the corresponding changes here.

@amartini51 amartini51 marked this pull request as draft September 26, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing gap/padding between social icons in the footer
3 participants